Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gray colors palette to Material Design palette #796

Open
ansivgit opened this issue Feb 17, 2025 · 1 comment
Open

Change gray colors palette to Material Design palette #796

ansivgit opened this issue Feb 17, 2025 · 1 comment
Labels

Comments

@ansivgit
Copy link
Collaborator

ansivgit commented Feb 17, 2025

📝 Describe the refactoring task

Since we don't know what palette our constants are based on now, we would like to redefine the color constants according to the Material Design palette. And name the colors variables as color-gray-xxx.

📍 Code location

src/core/styles/_constants.scss

🛠️ Suggested improvement

E.g.our color variable $color-gray-400: hsl(0deg 0% 69%); // #afafaf will be changed to 400 from MD palette: $color-gray-400: hsl(204deg 3%, 71%); // #b3b6b8

ℹ️ Additional context

We need this so that we can interpolate the color palette (get colors like gray-700, gray-800 etc.)

✅ Definition of Done (DoD):

All gray palette is changed due MD palette

@ansivgit ansivgit added this to RS Site Feb 17, 2025
@ansivgit ansivgit moved this to Backlog in RS Site Feb 17, 2025
@ansivgit ansivgit changed the title Change grey colors palette to Material Design palette Change gray colors palette to Material Design palette Feb 17, 2025
@ansivgit ansivgit added the good first issue Good for newcomers label Feb 17, 2025
@oibioib
Copy link

oibioib commented Feb 26, 2025

I can fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants