Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entrypoint.sh: sed replace timeout #77

Merged
merged 1 commit into from
Nov 27, 2023
Merged

entrypoint.sh: sed replace timeout #77

merged 1 commit into from
Nov 27, 2023

Conversation

tuxcanfly
Copy link
Contributor

@tuxcanfly tuxcanfly commented Nov 27, 2023 •
edited by coderabbitai bot
Loading

Overview

Fixes #78

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Configuration Updates
    • Improved the application's responsiveness by adjusting timeout settings.
    • Enhanced search capabilities within the app by enabling indexing of all keys.
    • Updated the operational mode to "validator" for better network participation.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2023 •
edited
Loading

Walkthrough

The update to the celestia-app configuration aims to improve the block time on the devnet by adjusting timeout settings and enabling full indexing. The config.toml file is modified to set both timeout_commit and timeout_propose to "1s" and to index all keys, while also changing the node mode to "validator".

Changes

File(s) Change Summary
entrypoint.sh Updated timeout_commit and timeout_propose to "1s", set index_all_keys to true, and changed mode to "validator" in config.toml.

Assessment against linked issues

Objective Addressed Explanation
#78: Improve devnet block time to ~2s ✅ The changes to timeout_commit and timeout_propose are intended to directly address the slow block time issue.
#78: Ensure celestia-app config changes are reflected ✅ The use of sed to update config.toml ensures that the latest configuration is applied, addressing the issue of outdated settings.

Poem

In the code's deep burrow, a rabbit did tweak,
Timers set swift, no more do they creak.
Blocks now race by, with a validator's grace,
A digital hop in the blockchain's embrace. 🐇💻✨

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@tuxcanfly tuxcanfly marked this pull request as ready for review November 27, 2023 15:44
coderabbitai[bot]
coderabbitai bot reviewed Nov 27, 2023
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 47023b9 and 1b81344.
Files selected for processing (1)
  • entrypoint.sh (1 hunks)
Additional comments: 2
entrypoint.sh (2)

  • 38-38: Setting index_all_keys to true can have performance implications, especially for larger datasets. Ensure that this change is well-documented and that the performance impact has been considered.

  • 39-39: Changing the mode to "validator" is a significant operational change. Confirm that all necessary preparations, such as stake delegation and security measures, are in place before running the node in validator mode.

entrypoint.sh Show resolved Hide resolved
entrypoint.sh Show resolved Hide resolved
entrypoint.sh Show resolved Hide resolved
jcstein
jcstein approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

nashqueue
nashqueue approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@nashqueue nashqueue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@nashqueue nashqueue merged commit 3644927 into main Nov 27, 2023
7 checks passed
@nashqueue nashqueue deleted the tux/devnet-block-times branch November 27, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@nashqueue nashqueue nashqueue approved these changes

@jcstein jcstein jcstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

devnet block time is slow
3 participants
@tuxcanfly @jcstein @nashqueue