Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Imports #4

Open
BadgerOnABike opened this issue Oct 29, 2024 · 0 comments
Open

Function Imports #4

BadgerOnABike opened this issue Oct 29, 2024 · 0 comments

Comments

@BadgerOnABike
Copy link

Hey Air!

Was just watching WFCC 2024 and figured I'd check out your package!

I have a couple suggestions that can help speed some things up if you like!

Biggest one is importing functions:
terra::minmax
https://github.com/heyairf/fireexposuR/blob/8cc26b1477d0ad405161d5969a5cd25e64347de0/R/fire_exp_adjust.R#L37C16-L37C30

You can call those with the @importFrom to ensure you have them in the space as calling the package to pull a function is actually less efficient (it seems weird but that's what I've learned!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant