Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: nested lists to tibble #160

Open
florianm opened this issue Oct 21, 2024 · 0 comments
Open

Refactor: nested lists to tibble #160

florianm opened this issue Oct 21, 2024 · 0 comments
Assignees
Labels
tech-debt Reduce technical debt
Milestone

Comments

@florianm
Copy link
Collaborator

florianm commented Oct 21, 2024

Feature

Currently we use different approaches to turn nested lists into tibbles.
Is it worth harmonising the approaches? Is there a best, most canonical/readable/maintainable way?

# odata_entitylist_service_get: ds$value is a simple nested list
nested_list |> purrr::map_df(ds$value, ~ tibble::as_tibble(.x))


# entity_changes: list of lists, inner list names should become column names
|> purrr::map_df(~ purrr::map_df(.x, ~ tibble::as_tibble(.x)))

Earlier code like project_detail might benefit from a more canonical approach too.

@florianm florianm added the tech-debt Reduce technical debt label Oct 21, 2024
@florianm florianm added this to the Maintenance milestone Oct 21, 2024
@florianm florianm self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Reduce technical debt
Projects
None yet
Development

No branches or pull requests

1 participant