Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace multiple set state method calls with a single set state method call. #42

Open
joshuaplusone opened this issue Sep 4, 2018 · 0 comments

Comments

@joshuaplusone
Copy link
Contributor

virtual bool setStarting(std::function<int()> state_method) = 0;
virtual bool setExecute(std::function<int()> state_method) = 0;
virtual bool setCompleting(std::function<int()> state_method) = 0;
virtual bool setAborting(std::function<int()> state_method) = 0;
virtual bool setClearing(std::function<int()> state_method) = 0;
virtual bool setStopping(std::function<int()> state_method) = 0;
virtual bool setResetting(std::function<int()> state_method) = 0;
virtual bool setSuspending(std::function<int()> state_method) = 0;
virtual bool setUnsuspending(std::function<int()> state_method) = 0;
virtual bool setHolding(std::function<int()> state_method) = 0;
virtual bool setUnholding(std::function<int()> state_method) = 0;

should be replaced with

virtual bool setStateMethod(StatesEnum state, std::function<int()> state_method) = 0;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant