Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering custom weights in multiplier menu is tedous #229

Open
gyhtomit opened this issue Oct 4, 2023 · 2 comments
Open

Entering custom weights in multiplier menu is tedous #229

gyhtomit opened this issue Oct 4, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gyhtomit
Copy link

gyhtomit commented Oct 4, 2023

Describe the bug
Always requiring an integer part in the weight multiplier makes trying to enter custom weights rather tedious. E.g. adapting the default French Press recipe from 30.0g coffee to 45.0g coffee requires moving the cursor several times.
This happens because the app inserts a 0 as an integer part, if all digits left of the dot are deleted.

To Reproduce

  1. Go to any recipe and open the multiplier menu (scale button, top right)
  2. Place the cursor on the very right in the coffee multiplier field ("30.0|")
  3. Repeatedly deleting digits by pressing the backspace button results in:
    1. "30.|0"
    2. "30|0.0"
    3. "3|0.0"
    4. "|0.0"

Alternatively placing the cursor to the left of the dot ("30|.0") and repeatedly pressing backspace results in a zero being inserted in the integer part:

  1. "3|.0"
  2. "|0.0"

Expected behavior
Adapting the weights should be as easy as

  1. Deleting the current value
  2. writing the desired value

Screenshots
none. Will provide if needed.

Smartphone:

  • Device: Pixel 4a
  • Android: 13
  • App Version: 1.20.0 (via F-Droid)

Additional context
To actually change the 30.0g to 45.0g I have to enter 45 before deleting the 30 which requires moving the cursor multiple times.

@gyhtomit gyhtomit added the bug Something isn't working label Oct 4, 2023
@KhaaL
Copy link

KhaaL commented Nov 25, 2023

Appriciate this bug report - I jist downloaded the app and was bugged by the same thing 😊

@rozPierog
Copy link
Owner

Agreed that it's not very intuitive, and/or broken. I have little to no time for Cofi work right at this very moment, but I'll be happy to merge a PR if somebody wants to fix it!

@rozPierog rozPierog added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants