Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could tito build --srpm --test bump setup.py version? #469

Open
praiskup opened this issue Aug 22, 2023 · 2 comments
Open

Could tito build --srpm --test bump setup.py version? #469

praiskup opened this issue Aug 22, 2023 · 2 comments
Labels
effort/medium Can be done in 1-2 days gain/medium Affects multiple users RFE This issue is a Request For Enhancement (Feature)

Comments

@praiskup
Copy link
Member

There's a convenient logic to bump Python version for tito tag, though it would be very nice if we could dump the "pre-release" version into the Python version string.

Background story: I'm thinking about self-identifying copr-rpmbuild script in its logs; if some pre-release copr-rpmbuild is being run, it would be nice to dump into logs the full version, e.g. 0.69-1.git.4.6f7e09b instead of just 0.69.

@FrostyX
Copy link
Member

FrostyX commented Aug 22, 2023

We have the undocumented "templates" feature, I am using it here:

https://github.com/FrostyX/tracer/blob/master/rel-eng/templates/version.rb
https://github.com/FrostyX/tracer/blob/master/rel-eng/tito.props

but IIRC it is used when tagging, not when building. Maybe we can improve it.

@FrostyX FrostyX added the RFE This issue is a Request For Enhancement (Feature) label Aug 22, 2023
@FrostyX FrostyX added effort/medium Can be done in 1-2 days gain/medium Affects multiple users labels Jan 1, 2024
@praiskup
Copy link
Member Author

The problem is that setup.py is added to the git archive tarball. And we don't want to modify it on the fly - or maybe, do we? But that would be precedent, even with the "spec file modifications" for build --test we only modify the spec file copy that is not archived in the underlying tarball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Can be done in 1-2 days gain/medium Affects multiple users RFE This issue is a Request For Enhancement (Feature)
Projects
None yet
Development

No branches or pull requests

2 participants