Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 3 - leftovers #155

Open
1 of 8 tasks
rpoleski opened this issue Dec 2, 2024 · 0 comments
Open
1 of 8 tasks

Version 3 - leftovers #155

rpoleski opened this issue Dec 2, 2024 · 0 comments

Comments

@rpoleski
Copy link
Owner

rpoleski commented Dec 2, 2024 •
edited
Loading

  • why t_eff is not in ModelParameters._primary_source_params_head?
  • What is the purpose of Model._N_source_attr?
  • review documents/MM_v3.md
  • move documents/MM_v3.md to v4
  • magnificationcurve.py - remove comment in get_magnification()
  • uncomment tests/test_FitData.py::TestFSPLGradient2::test_dAdu_FSPLError
  • uncomment or remove: test_PointLensWithShear.py class test_errors
  • parameters of methods should be checked and give warnings when they're don't match allow names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rpoleski