Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message on local environment when contracts are not set #269

Open
jurajpiar opened this issue Apr 29, 2020 · 4 comments
Open

Show message on local environment when contracts are not set #269

jurajpiar opened this issue Apr 29, 2020 · 4 comments
Labels
dev Developer experience

Comments

@jurajpiar
Copy link
Member

This happens when I restart the network and the network id is no longer valid. I change the id, restart the app and all is fine until I login to my wallet.

Screenshot 2020-04-29 at 20 37 59

@jurajpiar
Copy link
Member Author

It turns out I had to redeploy the RNSSuite after restarting the node.

@jessgusclark
Copy link
Member

@jurajpiar I'm glad you figured it out!

If you need, I wrote a gist to pull the values from a local ganache network here: https://gist.github.com/jessgusclark/08c728d7e5aac1eba7906d3dd8de1679

@jurajpiar
Copy link
Member Author

@jessgusclark , I don't think this should have been closed tho. The fact that I had a wrong env_id does not change the fact that this error should have been caught and this horrible error message should not have replaced the ui.

@jessgusclark
Copy link
Member

Okay. I'll reopen and update the title of the issue if that is alright.

@jessgusclark jessgusclark reopened this May 5, 2020
@jessgusclark jessgusclark changed the title App breaks on wrong NETWORK_ID (REACT_APP_ENVIRONMENT_ID) Show message on local environment when contracts are not set May 5, 2020
@ilanolkies ilanolkies added the dev Developer experience label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Developer experience
Projects
None yet
Development

No branches or pull requests

3 participants