Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When unsubscribing, don't update subcsription list until Ack is received #105

Open
emiltin opened this issue Jan 23, 2025 · 0 comments
Open

Comments

@emiltin
Copy link
Collaborator

emiltin commented Jan 23, 2025

In testing Cross RS4S there was an instance where a repeated alarm was incorectly reported.

From rsmp-nordic/rsmp_validator#499:

I think the problem is that a status update is send after the unsubscribe. However the status is receive before the unsubscribe is acknowledged. Probably the status update was already in flight when the unsubscribe was received.

When unsubscribing, the subscription list in the rsmp gem is updated to remove the particular status:

def unsubscribe_to_status component_id, status_list, options={}

From that point, a status update will be checked for repeat values.

The subscription list should not be updated until the unsubscribe is acknowledged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant