Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to respond to incorrect security codes #144

Open
emiltin opened this issue Dec 14, 2023 · 4 comments
Open

How to respond to incorrect security codes #144

emiltin opened this issue Dec 14, 2023 · 4 comments

Comments

@emiltin
Copy link
Contributor

emiltin commented Dec 14, 2023

If a command cannot be exectured, the normal behaviour is to send back the current values.
But if a command include incorrect security codes, it's not a good idea to return the correct codes.

We should somehow clarify or allow this in the core spec, although security codes is specific to the TLC sxl.

Previous discussion:
rsmp-nordic/rsmp#47

Or we wait until a possible v4 provides a new security model.

@otterdahl
Copy link
Contributor

@emiltin
Copy link
Contributor Author

emiltin commented Jan 18, 2024

To clarify, security codes is not a concept in core, but is specific to the TLC SXL. But not sending back the current values is not consistent with the current core spec.

@emiltin
Copy link
Contributor Author

emiltin commented Jan 18, 2024

Another option would be to remove security codes from the TLC SXL. This would not require any change to core.

@emiltin
Copy link
Contributor Author

emiltin commented Jan 14, 2025

Security codes is not secure, but rather just a way to check that you're sending a command to the right controller. They're also send in cleartext.

Proposal is to handle this in the TLC SXL:

  1. Redefine this to a "control" code, and not as sensitive info.
  2. Remove the section in the TLC SXL on security codes, since they override the core mechanism of command responses: https://rsmp-nordic.github.io/rsmp_sxl_traffic_lights/1.2.1/security_codes.html?highlight=security. The implication would be that the correct security code is returned in the command response. This should be ok if it's not considered sensitive info anymore.
  3. We should remove these security attributes in an upcoming major version and replace them with a better more secure model of authentication and authorization in the core spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants