Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Line spacing customisable #1477

Closed
hayden-MB opened this issue Oct 16, 2024 · 3 comments · Fixed by #1479
Closed

[FR] Line spacing customisable #1477

hayden-MB opened this issue Oct 16, 2024 · 3 comments · Fixed by #1479
Labels
feature a feature request or enhancement help wanted ❤️ we'd love your help!

Comments

@hayden-MB
Copy link
Contributor

Hello!

Bookdown using the GitBook style via BookML is used in our institution as an accessibility solution. This works well in allowing students to apply their own accommodations or just preferences to the course notes without having to contact the course organiser. However, this menu does not allow the user to change the line spacing. 1.5 or 2 line spacing is a common accommodation for students, and as such it would a useful addition to this menu.

What I would want to happen: that the user can edit the line spacing without outside help
Exactly what I would want: an addition to the 'A' menu on the gitbook style which allows line spacing to be chosen.

Thank you!!

@yihui
Copy link
Member

yihui commented Oct 16, 2024

This shouldn't be hard if one knows JavaScript and a little CSS (line spacing is controlled by the CSS property line-height), but I don't have time for this task. The place to implement this feature is https://github.com/rstudio/bookdown/blob/main/inst/resources/gitbook/js/plugin-fontsettings.js We will welcome a pull request. Thanks!

@hayden-MB
Copy link
Contributor Author

I will look into doing that.
Pardon my ignorance, but is there a simple way of checking changes? i.e. viewing an example document locally before pushing.

@cderv cderv added help wanted ❤️ we'd love your help! feature a feature request or enhancement labels Oct 17, 2024
@hayden-MB
Copy link
Contributor Author

I have written code which I hope would do the job, but without a way of checking I wouldn't want to push. Any advice is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement help wanted ❤️ we'd love your help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants