Return an error when getting header attributes for invalid metadata version #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriygm
changed the title
jmwoliver
force-pushed
the
error-with-invalid-header-ver
branch
from
ec19d67 to
6882c03
Compare
jmwoliver
force-pushed
the
error-with-invalid-header-ver
branch
from
6882c03 to
24ab8ec
Compare
|
Hey @andriygm, thanks so much for contributing! Sorry for the delay in responding. This change looks good, I'm going to merge this in now. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning an empty header attributes object, which causes no metadata population and later a less helpful "metadata is missing required fields" error, we should bubble this up immediately so the user knows the metadata version is not known/supported.