Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace detection and removal #3

Open
atheriel opened this issue Feb 2, 2022 · 0 comments
Open

Whitespace detection and removal #3

atheriel opened this issue Feb 2, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@atheriel
Copy link
Collaborator

atheriel commented Feb 2, 2022

Some internal discussion indicates that "user accidentally copied some whitespace along with the database password" is a common source of errors with existing tooling. It may be sensible for the rskey CLI to detect extra whitespace automatically and remove it.

Some notes:

  • Doing this quietly could in theory surprise users, so we may also need to tell them in a sensible way.
  • Some secrets (rarely, I'd guess) may actually need to contain leading or trailing whitespace, so we'd need to add a flag to turn this behaviour off.
  • A related issue is "user accidentally copied the database password with surrounding " marks included".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant