Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement DNSSL in cmd/radvd #45

Closed
stapelberg opened this issue May 20, 2020 · 5 comments
Closed

implement DNSSL in cmd/radvd #45

stapelberg opened this issue May 20, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers good-for-stream https://www.twitch.tv/stapelberg

Comments

@stapelberg
Copy link
Contributor

stapelberg commented May 20, 2020

https://tools.ietf.org/html/rfc6106#section-5.2

cc @mdlayher

I think we talked about this but then I didn’t file an issue? This could be a good thing to do on stream.

@stapelberg stapelberg added enhancement New feature or request good first issue Good for newcomers labels May 20, 2020
@masihtehrani
Copy link

@stapelberg @mdlayher
I'd like to work on it
can you more explain about the issue

@stapelberg
Copy link
Contributor Author

I can do that if we end up not working on this on stream on Saturday.

The effort to explain this significantly outweighs just doing it, and you’ll be able to watch us do it (either live on https://www.twitch.tv/mdlayher or in the recording).

@mdlayher
Copy link
Contributor

Indeed, this will be a ~5-10 line change so probably not worth having someone else do unfortunately when Michael and I have plans to work on this in a couple of days. Thanks for reaching out though.

@masihtehrani
Copy link

Indeed, this will be a ~5-10 line change so probably not worth having someone else do unfortunately when Michael and I have plans to work on this in a couple of days. Thanks for reaching out though.

Ok, have best for you 👍

@stapelberg stapelberg added the good-for-stream https://www.twitch.tv/stapelberg label May 23, 2020
@stapelberg stapelberg self-assigned this May 23, 2020
@stapelberg
Copy link
Contributor Author

fixed with commit fe68c2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers good-for-stream https://www.twitch.tv/stapelberg
Projects
None yet
Development

No branches or pull requests

3 participants