update the way we glob team files #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+23
to
+31
| code_team = TeamPlugins::Ownership.for(team) | ||
|
|
||
| Dir.glob(code_team.owned_globs).each do |filename| | ||
| map[filename] = team | ||
| end | ||
|
|
||
| # Remove anything that is unowned | ||
| TeamPlugins::Ownership.for(team).unowned_globs.each do |glob| | ||
| Dir.glob(glob).each do |filename| | ||
| map.delete(filename) | ||
| end | ||
| # Remove anything that is unowned by this team | ||
| Dir.glob(code_team.unowned_globs).each do |filename| | ||
| map.delete(filename) |
There was a problem hiding this comment.
this change will make these globs a bit faster
The main reason I'd expect this is that it only tries recursing through the code base once for owned and once for unowned w/ all the glob patterns, as opposed to recursing once per glob.
It might be possible to improve further by doing one giant glob, and using File#fnmatch? to exclude unowned patterns. benchmark-ips + benchmark-memory is super helpful for comparing multiple implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinemde says that this change will make these globs a bit faster which is important when you're running this on a large codebase.