Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's up
pks uses
enforcement_globs_ignore
which bin/packs doesn't have. Now that the ZP code is using this we are failingbin/packwerk update-todo
.This pr introduces
use_pks
to the config so that we can usepks check
in ZP CI.How to test
gem 'packs', require: false, path: '../packs'
config.use_pks = true
toconfig/packs.rb
(line 9)bundle
(verify you're pointing to your local packs with
bundle show packs
)bin/packs lint_package_todo_yml_files
set
config.use_pks = false
and run the commands:(you can tell it's running packwerk by all the dots)
bin/packs check -> fails
bin/packs validate -> fails
bin/packs update -> fails