Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add use_pks #159

Merged
merged 6 commits into from
Jun 12, 2024
Merged

add use_pks #159

merged 6 commits into from
Jun 12, 2024

Conversation

tstannard
Copy link
Contributor

@tstannard tstannard commented Jun 11, 2024

  • I bumped the gem version (or don't need to) 💎

What's up

pks uses enforcement_globs_ignore which bin/packs doesn't have. Now that the ZP code is using this we are failing bin/packwerk update-todo.

This pr introduces use_pks to the config so that we can use pks check in ZP CI.

How to test

  1. In ZP (or whatever other repo is using packs) gemfile update path to point to your local version
  2. gem 'packs', require: false, path: '../packs'
  3. Add config.use_pks = true to config/packs.rb (line 9)
  4. run bundle
    (verify you're pointing to your local packs with bundle show packs)
  5. run bin/packs lint_package_todo_yml_files
  6. 🎉 see success message!
    image
image

set config.use_pks = false and run the commands:
(you can tell it's running packwerk by all the dots)
bin/packs check -> fails
bin/packs validate -> fails
bin/packs update -> fails

@tstannard tstannard changed the title add use_pks and use it in update add use_pks Jun 11, 2024
lib/packs.rb Outdated
Comment on lines 56 to 60

else
Private.system_with("bin/packwerk check #{files.join(' ')}")

end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you could remove these extra lines

@tstannard tstannard merged commit 8f8ded1 into main Jun 12, 2024
6 checks passed
@tstannard tstannard deleted the ts/use_pks branch June 12, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants