Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary reorder with --auto-correct #8

Closed
juanca opened this issue Aug 21, 2024 · 1 comment
Closed

Unnecessary reorder with --auto-correct #8

juanca opened this issue Aug 21, 2024 · 1 comment

Comments

@juanca
Copy link

juanca commented Aug 21, 2024

I didn't expect to see this diff after running bin/pks check-unnecessary-dependencies --auto-correct

--- a/packs/p/b/a/package.yml
+++ b/packs/p/b/a/package.yml
@@ -1,9 +1,7 @@
-layer: a
 enforce_dependencies: strict
 enforce_privacy: strict
 enforce_layers: true
-enforce_folder_privacy: strict
-
+layer: a
 dependencies:
 - packs/f/p
 - packs/f/r
@@ -13,7 +11,6 @@ dependencies:
 - packs/p/b/i
 - packs/p/b/pb
 - packs/p/b/pb2
-- packs/p/p/pcd
 - packs/p/p/pd
 - packs/p/p/rp
 - packs/t/a/a
@@ -24,3 +21,4 @@ ignored_dependencies:
 - packs/p/o/c
 - packs/p/o/e
 - packs/p/p/t
+enforce_folder_privacy: strict

At best, I would expect top-level keys to be ordered alphabetically. This seems a bit random. I will try to see if I can make ordering a bit more deterministic.

@juanca
Copy link
Author

juanca commented Aug 30, 2024

Closed by #9

@juanca juanca closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant