Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use custom filename && directory name to store configs #340

Closed
feruzoripov opened this issue Aug 16, 2023 · 2 comments · Fixed by #341
Closed

Allow to use custom filename && directory name to store configs #340

feruzoripov opened this issue Aug 16, 2023 · 2 comments · Fixed by #341
Labels
Milestone

Comments

@feruzoripov
Copy link
Contributor

Problem

The current solution of hardcoding the filename and directory name to settings.yml and settings folder is not ideal, as it can lead to conflicts if the same filename or directory name is already being used by other logics.

A better solution is to add two configuration fields, Config.file_name and Config.dir_name, which will allow users to specify their own filename and directory name. This will make it possible to avoid conflicts and it will also give users more flexibility in how they store their data.

Solution

Added two configuration fields:

  • Config.file_name for filename
  • Config.dir_name for directory name
@feruzoripov
Copy link
Contributor Author

feruzoripov commented Aug 16, 2023

PR: #341

@pkuczynski
Copy link
Member

Sounds reasonable. @cjlarose what do you think?

@pkuczynski pkuczynski added this to the Next milestone Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants