-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Unicodify in 2 extensions #89
Comments
Do you mean a recommended extension in Firefox or Thunderbird? Thunderbird does not yet have any standard criteria for their recommended extensions, but I believe even with the experimental functionality it could still be a recommended extension in Firefox. The Unicode autocorrection is not without choice, as they can be enabled/disabled from the options page and individual autocorrections can be reverted while typing by pressing backspace. I would not want to remove the autocorrection functionality, as it is a core part of this add-on. This was actually already split in two parts, as it was originally part of @rugk's Awesome Emoji Picker add-on, which now supports just the Unicode Emoji autocorrection and this add-on was created for the Unicode symbol autocorrection. Anyway, in the next update we could temporarily deemphasize the Unicode autocorrection feature in the AMO/ATN listing, which should allow removing the experimental label. Would that be acceptable for you? |
👍
Note that the experimental label is one thing. What Firefox aka Mozilla calls a “recommend extension” is another thing. Even if the extension would not be experimental (which is just a flag set by us), it would still be not recommend in that sense. Thus, the warning that the extension “is not actively monitored” is just always a warning of Mozilla that explains the extension is not part of their suggested and extra-strongly vetted add-ons. See https://support.mozilla.org/kb/add-on-badges for more information.
Yeah, but unlikely to succeed. If it would, the split would certainly be useful. Anyway, just FYI. About the idea itself hmm, yeah, I can see where it comes from. But I agree you can disable everything you don't need and once done so, it should come with no downsides. So for now, I also tend to keep it together, |
I would like both, but I understood it exists only for Firefox yet.
I would say not, but I don't know.
I said that a little too quickly, but I hope you understand: I spoke about the UI nature which is not the same. (Auto-correction gives the choice to not do it, but nothing else.)
I don't understand: Does the text conversion via context menu use this core ?
OK, I didn't know.
Don't do that just for me. |
I already read it.
Why ?
I think so. Also because it would make each part smaller, which give less work to AMO devs to check it.
OK, but if you think that it's too soon to ask that, so I should wait anyway ?
No downsides for usage, I agree.
Basically I would say that if your extension contains different things which have no link between, it tend to be better to be split in several smaller extensions. But in the meantime I thought about custom auto-correction (end of #30 ). I would say that it mainly depends if there is shared code between them, or not. |
Thunderbird is working on establishing a criteria for this. I was recently elected to the Thunderbird Council, so I will definitely advocate that they finish this.
By "core", I meant that it is the main functionality of the add-on (more than 50%), but it does use separate code.
Feedback from the community is always very helpful. We were hoping that the autocorrection feature could be finished and enabled by default, but unfortunately it does not look like that is going to happen anytime soon (new APIs are needed: #4 (comment)), so this is probably a good solution in the meantime.
This add-on is already extremely small compared to most add-ons on AMO/ATN. We used modern JS features which significantly reduced the amount of code needed. I agree in general about making modular add-ons that "do one thing well", but users also do not want to install a bunch of add-ons with related functionality when they could install just a single add-on.
What do you mean by custom autocorrection? The auto superscript/subscript requested in #66? The add-on already supports superscript and I just enabled a subscript Unicode font in #84.
There is no shared code, but the idea for the add-on is to make use of various Unicode symbols and other characters, so it is all related. |
Nice :-)
Nice, so, do as you feel :-)
msg -> message Text Insert, the point "Define shortcut-replacements", does that, but:
Do you want I write a new feature request for that ?
It could be a subset, probably.
Why did you split Unicodify from Awesome Emoji Picker ? |
I do not believe this would be the correct add-on to add support for general (non-Unicode related) autocorrections. However, @rugk wants to extract out the autocorrection code into a separate library, which could be used by any add-ons. See #42 and the repository: https://github.com/TinyWebEx/TextModification/.
@rugk wanted their Awesome Emoji Picker add-on to only focus on emojis and not other Unicode symbols. See rugk/awesome-emoji-picker#106 for background. |
Background
Proposed solution
Split Unicodify – Text transformer in 2 parts:
This split makes sense since Unicodify makes substantially 2 different things:
Then, you'll be able to request the Recommended badge for the 1st, while letting the 2nd as experimental. :-)
Additional context
I suppose the reason you consider Unicodify – Text transformer as experimental is contained in auto-correction part, and the part which convert text is fine.
(Tell me if I'm wrong!)
The text was updated successfully, but these errors were encountered: