From 1965d5b062f5578c1059f1ced9c99b2a09ddc5c5 Mon Sep 17 00:00:00 2001 From: sunko Date: Thu, 7 Mar 2024 18:51:20 +0200 Subject: [PATCH 1/6] challenge-one-task --- public/challenge-contributions/1/asavov.html | 40 ++++++++++++- .../1/asavovStyles.css | 56 +++++++++++++++++++ 2 files changed, 95 insertions(+), 1 deletion(-) create mode 100644 public/challenge-contributions/1/asavovStyles.css diff --git a/public/challenge-contributions/1/asavov.html b/public/challenge-contributions/1/asavov.html index db343b2..8eec52f 100644 --- a/public/challenge-contributions/1/asavov.html +++ b/public/challenge-contributions/1/asavov.html @@ -4,8 +4,46 @@ Challenge 1 + -

This is the template HTML file for this challenge.

+
+
+

Basic Article

+

Dogs

+

Dogs can be good friends!

+

Dogs need to be walked every day!

+

Breeds:

+
    +
  1. Gonche
    2. +
  2. Barak
    3. +
  3. Dobermann
    4. +
+

Images:

+ +

Cats

+

Cats can climb very high!

+

Cats can jump from very high!

+

Ducks

+

Ducks can fly!

+

Ducks can swim!

+

Pigs

+

Pigs get dirty!

+

Pigs can eat almost everything!

+
+
+ +
+ Date released 07.03.2024 +
+ +
+
+
+
\ No newline at end of file diff --git a/public/challenge-contributions/1/asavovStyles.css b/public/challenge-contributions/1/asavovStyles.css new file mode 100644 index 0000000..79febb4 --- /dev/null +++ b/public/challenge-contributions/1/asavovStyles.css @@ -0,0 +1,56 @@ +html { + background-color: black; +} +body { + font-size: 1rem; + margin: 0; +} +footer { + display: flex; + justify-content: end; +} +p { + margin: 0; +} +ol { + margin: 0; +} +ul { + margin: 0; +} +h3 { + margin: 5px; +} +figure { + width: 20px; + height: 20px; + margin: 5px; +} +.article-intro { + text-align: center; + margin: 0; +} +.content-wrapper { + width: 800px; + margin: 20px auto; + background-color: white; + padding: 20px 15px; + background-image: url("https://cdn.wallpapersafari.com/88/54/VsRXHO.jpg"); +} +a.link1:hover { + text-decoration: underline dotted red; +} +a.link2:hover { + text-decoration: green wavy underline; +} +a.link3:hover { + text-decoration: underline orange; +} +.footer-image { + width: 20px; + height: 20px; +} + + + + From f7ba8858b9103f92549efc163838cbd78bbb8013 Mon Sep 17 00:00:00 2001 From: sunk0 Date: Fri, 8 Mar 2024 16:02:00 +0200 Subject: [PATCH 2/6] pr-request-changes --- public/challenge-contributions/1/asavov.html | 171 ++++++++++++++----- 1 file changed, 124 insertions(+), 47 deletions(-) diff --git a/public/challenge-contributions/1/asavov.html b/public/challenge-contributions/1/asavov.html index 8eec52f..d602db8 100644 --- a/public/challenge-contributions/1/asavov.html +++ b/public/challenge-contributions/1/asavov.html @@ -1,49 +1,126 @@ - - - - Challenge 1 - - - -
-
-

Basic Article

-

Dogs

-

Dogs can be good friends!

-

Dogs need to be walked every day!

-

Breeds:

-
    -
  1. Gonche
    2. -
  2. Barak
    3. -
  3. Dobermann
    4. -
-

Images:

- -

Cats

-

Cats can climb very high!

-

Cats can jump from very high!

-

Ducks

-

Ducks can fly!

-

Ducks can swim!

-

Pigs

-

Pigs get dirty!

-

Pigs can eat almost everything!

-
-
- -
- Date released 07.03.2024 -
- -
-
-
-
- - \ No newline at end of file + + + + Challenge 1 + + + +
+
+

Basic Article

+

Dogs

+

Dogs can be good friends!

+

Dogs need to be walked every day!

+

Breeds:

+
    +
  1. Gonche
    2. +
  2. Barak
    3. +
  3. Dobermann
    4. +
+

Images:

+ +

Cats

+

Cats can climb very high!

+

Cats can jump from very high!

+

Ducks

+

Ducks can fly!

+

Ducks can swim!

+

Pigs

+

Pigs get dirty!

+

Pigs can eat almost everything!

+
+
+ +
+ Date released 07.03.2024 +
+ +
+
+
+
+ + From b47075cb064c847ea7d3eec43716e39bfa1d08fd Mon Sep 17 00:00:00 2001 From: sunk0 Date: Fri, 8 Mar 2024 16:02:39 +0200 Subject: [PATCH 3/6] remove-css-file --- .../1/asavovStyles.css | 56 ------------------- 1 file changed, 56 deletions(-) delete mode 100644 public/challenge-contributions/1/asavovStyles.css diff --git a/public/challenge-contributions/1/asavovStyles.css b/public/challenge-contributions/1/asavovStyles.css deleted file mode 100644 index 79febb4..0000000 --- a/public/challenge-contributions/1/asavovStyles.css +++ /dev/null @@ -1,56 +0,0 @@ -html { - background-color: black; -} -body { - font-size: 1rem; - margin: 0; -} -footer { - display: flex; - justify-content: end; -} -p { - margin: 0; -} -ol { - margin: 0; -} -ul { - margin: 0; -} -h3 { - margin: 5px; -} -figure { - width: 20px; - height: 20px; - margin: 5px; -} -.article-intro { - text-align: center; - margin: 0; -} -.content-wrapper { - width: 800px; - margin: 20px auto; - background-color: white; - padding: 20px 15px; - background-image: url("https://cdn.wallpapersafari.com/88/54/VsRXHO.jpg"); -} -a.link1:hover { - text-decoration: underline dotted red; -} -a.link2:hover { - text-decoration: green wavy underline; -} -a.link3:hover { - text-decoration: underline orange; -} -.footer-image { - width: 20px; - height: 20px; -} - - - - From a30c84246fffd25b3768392d417f6635784e4394 Mon Sep 17 00:00:00 2001 From: sunk0 Date: Fri, 8 Mar 2024 16:08:04 +0200 Subject: [PATCH 4/6] validator-fixes --- public/challenge-contributions/1/asavov.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/public/challenge-contributions/1/asavov.html b/public/challenge-contributions/1/asavov.html index d602db8..b1b3fe9 100644 --- a/public/challenge-contributions/1/asavov.html +++ b/public/challenge-contributions/1/asavov.html @@ -110,6 +110,7 @@

Pigs

Thumbs up Date released 07.03.2024 @@ -117,6 +118,7 @@

Pigs

Thumbs up From 5cd1b6af60a141fd25c66c0d21897133573ece28 Mon Sep 17 00:00:00 2001 From: sunk0 Date: Mon, 11 Mar 2024 12:30:48 +0200 Subject: [PATCH 5/6] PR req changes --- public/challenge-contributions/1/asavov.html | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/public/challenge-contributions/1/asavov.html b/public/challenge-contributions/1/asavov.html index b1b3fe9..195c73b 100644 --- a/public/challenge-contributions/1/asavov.html +++ b/public/challenge-contributions/1/asavov.html @@ -17,17 +17,33 @@ justify-content: end; } p { + font-size: 1rem; margin: 0; } ol { + font-size: 1rem; margin: 0; } ul { + font-size: 1rem; + margin: 0; + } + h1 { + font-size: 2.986rem; + margin: 15px 0; + } + h2 { + font-size: 2.488rem; margin: 0; } h3 { + font-size: 2.074rem; margin: 5px; } + h4 { + font-size: 1.728rem; + margin: 0 0 10px 0; + } figure { width: 20px; height: 20px; @@ -39,7 +55,7 @@ } .content-wrapper { width: 800px; - margin: 20px auto; + margin: auto; background-color: white; padding: 20px 15px; background-image: url("https://cdn.wallpapersafari.com/88/54/VsRXHO.jpg"); @@ -97,6 +113,8 @@

Images:

Cats

+

Also known as small tigers.

+

Also known as big killers.

Cats can climb very high!

Cats can jump from very high!

Ducks

From e958c12fc0e2b8c92007a104191e2d17b0637a91 Mon Sep 17 00:00:00 2001 From: sunk0 Date: Mon, 11 Mar 2024 12:35:13 +0200 Subject: [PATCH 6/6] remove body font --- public/challenge-contributions/1/asavov.html | 1 - 1 file changed, 1 deletion(-) diff --git a/public/challenge-contributions/1/asavov.html b/public/challenge-contributions/1/asavov.html index 195c73b..40f2fbe 100644 --- a/public/challenge-contributions/1/asavov.html +++ b/public/challenge-contributions/1/asavov.html @@ -9,7 +9,6 @@ background-color: black; } body { - font-size: 1rem; margin: 0; } footer {