Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker CI build step too slow #2150

Open
goodlyrottenapple opened this issue Nov 2, 2023 · 1 comment
Open

Docker CI build step too slow #2150

goodlyrottenapple opened this issue Nov 2, 2023 · 1 comment
Assignees

Comments

@goodlyrottenapple
Copy link
Contributor

goodlyrottenapple commented Nov 2, 2023

The Docker setup in many CI runs takes in excess of 40 minutes, which means the actual tests get killed half way. Looking at the CI runs, there are a lot of cache misses, for this part of the Dockerfile:

RUN apt-get update \
&& apt-get upgrade --yes \
&& apt-get install --yes \
cargo \
clang-${LLVM_VERSION} \
cmake \
curl \
debhelper \
libboost-test-dev \
libcrypto++-dev \
libprocps-dev \
libssl-dev \
libyaml-dev \
llvm-${LLVM_VERSION}-dev \
llvm-${LLVM_VERSION}-tools \
maven \
python3 \
python3-pip
ARG USER=user
ARG GROUP
ARG USER_ID
ARG GROUP_ID
RUN groupadd -g ${GROUP_ID} ${GROUP} && useradd -m -u ${USER_ID} -s /bin/sh -g ${GROUP} ${USER}
USER ${USER}:${GROUP}
RUN mkdir /home/${USER}/workspace
WORKDIR /home/${USER}/workspace
ENV PATH=/home/${USER}/.cargo/bin:/home/${USER}/.local/bin:/usr/local/bin/:${PATH}
RUN curl -sSL https://install.python-poetry.org | python3 - \
&& poetry --version
RUN cargo install svm-rs --version 0.3.0 --locked \
&& svm install 0.8.13 \
&& solc --version

We should have a docker image for evm semantics which has solc and poetry installed and pushed to dockerhub like the base image and Z3 image.

@goodlyrottenapple goodlyrottenapple changed the title Docker CI too slow Docker CI build step too slow Nov 2, 2023
@Baltoli
Copy link
Contributor

Baltoli commented Nov 2, 2023

Two things to try here:

  • @ehildenb says there is a PR open to remove solc
  • We should try making timeouts more granular to avoid the docker image build killing the tests unfairly - does GitHub support this? @ehildenb looking into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants