Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new design for Our Team Section #2218

Merged
merged 32 commits into from
Jan 8, 2024

Conversation

Anmol-Baranwal
Copy link
Collaborator

Fixes Issue

resolves #2176

Changes proposed

image

Contributors

image

rupali-codes and others added 29 commits November 2, 2023 23:20
* feat: Add Swift Sub Category

* Fix small correction

* Update database/languages/swift.json

Co-authored-by: Christine Belzie <[email protected]>

---------

Co-authored-by: Christine Belzie <[email protected]>
* [ADDED]: BlockChain Category

* Changes done

* Update index.ts

* Update index.ts

* Changes made

* Update CategoryDescriptions.ts
* feat: add iconsax icon

* chore: update description

Co-authored-by: Rupali Haldiya <[email protected]>

---------

Co-authored-by: Anmol Baranwal <[email protected]>
Co-authored-by: Rupali Haldiya <[email protected]>
* Added 2 new podcasts

* Added Overpowered.AI podcast

* Added new link to podcasts

* fix: json structure

* chore: update description

Co-authored-by: Christine Belzie <[email protected]>

* chore: remove whitespace

Co-authored-by: Aftab Rehan <[email protected]>

---------

Co-authored-by: Anmol Baranwal <[email protected]>
Co-authored-by: Christine Belzie <[email protected]>
Co-authored-by: Aftab Rehan <[email protected]>
* UI libraries in fronted added

* added description for the UI libraries

* description update for materailui , antdesign, chakraui

* removed os tutorials
with slight color changes in maintainer section
Copy link

vercel bot commented Dec 23, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel.

@rupali-codes first needs to authorize it.

@github-actions github-actions bot added goal: new-feature New feature or request priority: high Making completely new feature labels Dec 23, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Anmol-Baranwal, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes
Done!

Just to let you know, we need to synchronize the dev branch from main. Otherwise, there will be huge conflicts.

Copy link
Collaborator

@aftabrehan aftabrehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent PR, @Anmol-Baranwal 💪 🚀 💯

Copy link

vercel bot commented Dec 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 5:46am

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anmol-Baranwal please fix this

image

@CBID2
Copy link
Collaborator

CBID2 commented Dec 25, 2023

The error is still there

@Anmol-Baranwal
Copy link
Collaborator Author

The error is still there

It needs authorization to deploy.

@rupali-codes
image

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anmol-Baranwal its showing two scrollbars, can you remove the one?
image

@Anmol-Baranwal
Copy link
Collaborator Author

I will do it after the exam (28th) :)

@rupali-codes rupali-codes added the in progress For large issues label Dec 28, 2023
@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes
It was not even my fault. Definitely caused by someone else since overall height was somewhat higher resulting in scrollbar.

image

I only did because you requested.

Fixed:
image

@CBID2
Copy link
Collaborator

CBID2 commented Dec 29, 2023

@rupali-codes It was not even my fault. Definitely caused by someone else since overall height was somewhat higher resulting in scrollbar.

image

I only did because you requested.

Fixed: image

How can the scrollbar be removed @Anmol-Baranwal?

@Anmol-Baranwal
Copy link
Collaborator Author

How can the scrollbar be removed @Anmol-Baranwal?

For accessibility purpose, browsers tend to show scrollbars when there is space to scroll in the viewport height.

If the whole container occupies full height, there will be no extra gap, and no scrollbar :)
Mission accomplished!

@CBID2
Copy link
Collaborator

CBID2 commented Dec 30, 2023

How can the scrollbar be removed @Anmol-Baranwal?

For accessibility purpose, browsers tend to show scrollbars when there is space to scroll in the viewport height.

If the whole container occupies full height, there will be no extra gap, and no scrollbar :) Mission accomplished!

I see.

@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes
Does this need any more changes?

Is there a deployment error. Let me know.

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all set, looks perfect to me

@rupali-codes rupali-codes merged commit 8f7bda6 into rupali-codes:dev Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-feature New feature or request in progress For large issues priority: high Making completely new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add new design of our team section