-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve the Support Section #2253
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @rupali-codes on Vercel. @rupali-codes first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, sarava338, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
Hi @sarava338. I closed your PR because it was not assigned to you yet. Please read our Contributing guide to get started. |
Hi @CBID2, So May I know when #2242 be unlocked and it can be assigned to me ? |
I just unlocked it @sarava338. Just mention your name in the comment section. |
@sarava338 What will happen is, even if this pull request is merged; the corresponding issue will not be closed. You can read this: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
To add onto @Anmol-Baranwal's point @sarava338, I reopened this PR so no need to create a new one. |
Hi @Anmol-Baranwal, oooh, I don't know about this. This is my first OSP. Thanks for letting me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Sarava33! :) As you continue your open source journey remember the following
- Read the contributing guide before you start your contribution
- Use keywords when linking your issue
@rupali-codes, please approve deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me.
No need of deployment, making a change in Readme won't break anything :)
Yeah sure, Thanks for the advise 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
@rupali-codes, can you deploy this? It won't merge if you don't. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Fixes Issue
Closes #2242
Changes proposed
README.md support section was updated.
Screenshots
Before

After

Note to reviewers
Can I be a cotributor ?