-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some ski areas are missing region metadata #139
Comments
Possibly follow up of #25 |
We are using photon for geocoding. For some reason it doesn't return a state for the Black Mountain location, example: https://photon.komoot.io/reverse?lon=-71.16572179999997&lat=44.17919490000001&lang=en |
Thanks for the photon info. I opened komoot/photon#838. To do these geocoding lookups and to display the ski area dots in the webapp, I am assuming there is a single coordinate calculated to represent each ski area. In |
If I recall correctly, we use the centroid of the polygon but I can't remember anymore. Likely if you search for centroid you will find it in the code. |
@russellporter as per komoot/photon#838, photon has fixed the issue so many more ski areas should now get |
Thanks! I've purged the cache so it should repopulate. However when the job ran last night it looks like the photon api calls were heavily rate-limited, so at the moment a lot of ski areas don't have any geocoding. I expect the data gaps should fill in over the next few days as the job runs nightly. |
Re-opening as there seems to be some issues with repopulating the geocode cache |
Ok looks good now |
Great. Locations looking much more complete. I think there might be an issue with ski areas in the Czech Republic. Example Aldrov - Prezidentský expres. If I use query {
"features": [
{
"geometry": {
"coordinates": [15.5161847732722, 50.6805566],
"type": "Point"
},
"type": "Feature",
"properties": {
"osm_id": 98362175,
"extent": [15.5160792, 50.6806249, 15.5162882, 50.6804853],
"country": "Czechia",
"city": "Vítkovice",
"countrycode": "CZ",
"postcode": "51238",
"county": "Liberec Region",
"type": "house",
"osm_type": "W",
"osm_key": "building",
"housenumber": "23",
"osm_value": "house",
"state": "Northeast"
}
}
],
"type": "FeatureCollection"
} But this location information doesn't get pulled in by OpenSkiMap. Possibly country name |
Another ski area missing country currently is Asahi Tengusuton (アサヒテングストン), although the photon lookup seems to include country: Expand for photon JSON response{
"features": [
{
"geometry": {
"coordinates": [132.3514367, 34.8233159],
"type": "Point"
},
"type": "Feature",
"properties": {
"osm_type": "W",
"osm_id": 60313965,
"extent": [132.3457409, 34.8262769, 132.3542857, 34.8166542],
"country": "Japan",
"osm_key": "waterway",
"city": "Hamada",
"countrycode": "JP",
"osm_value": "stream",
"postcode": "697-0631",
"name": "大石谷川",
"state": "Shimane Prefecture",
"type": "other"
}
}
],
"type": "FeatureCollection"
} |
I noticed that Black Mountain in New Hampshire is missing location fields
location__iso3166_2
andlocation__localized__en__region
:Compare that to nearby Wildcat Mountain:
What allows region lookup for Wildcat but not Black? If its values missing from underlying datasets like OpenStreetMap, I'm happy to contribute this information.
For my current use case, I'd like the ability to assign all ski areas in the United States to their respective states.
The text was updated successfully, but these errors were encountered: