Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crater test better incr comp #556

Open
spastorino opened this issue Dec 10, 2020 · 2 comments
Open

Make crater test better incr comp #556

spastorino opened this issue Dec 10, 2020 · 2 comments

Comments

@spastorino
Copy link
Member

We were discussing on Zulip about some simple ideas on how to test incr compilation better.

Maybe it could be nice to build crate versions N - 1 and then incrementally build crate versions N to better exercise incr comp code.

@pietroalbini
Copy link
Member

This might get messy, as Crater runs every build in a shared target directory. Not sure how much it would skew the results.

@michaelwoerister
Copy link
Member

For reference, during the initial development of incremental compilation we had the cargo-incremental tool that did something similar. The main problem I remember was that we tested large parts of a given crate's commit history and many commits were written against much older versions of Rust. But if you only test a few versions back that shouldn't be so much of a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants