Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

triagebot rfc_helper cannot deal with the file being renamed to the RFC number #1803

Open
RalfJung opened this issue May 2, 2024 · 0 comments · May be fixed by #1848
Open

triagebot rfc_helper cannot deal with the file being renamed to the RFC number #1803

RalfJung opened this issue May 2, 2024 · 0 comments · May be fixed by #1848
Labels
A-rfc-helper Area: the RFC helper

Comments

@RalfJung
Copy link
Member

RalfJung commented May 2, 2024

The RFC process says

Now that your RFC has an open pull request, use the issue number of the PR to update your 0000- prefix to that number.

However, rfcbot will create the "Rendered" link to point to the file "0000-*", which will then be a dead link that one has to manually update. The bot should probably update this link automatically?
@RalfJung RalfJung changed the title triagebot cannot deal with the file being renamed to the RFC number triagebot rfc_helper cannot deal with the file being renamed to the RFC number May 2, 2024
@RalfJung RalfJung mentioned this issue May 2, 2024
Merged
@ehuss ehuss added the A-rfc-helper Area: the RFC helper label Sep 12, 2024
@Urgau Urgau linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rfc-helper Area: the RFC helper
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve rendered link handler with proper edit and sha-based link Urgau/triagebot
2 participants
@ehuss @RalfJung