Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"r?" silently does nothing when the user is not a reviewer #1805

Open
RalfJung opened this issue May 3, 2024 · 2 comments
Open

"r?" silently does nothing when the user is not a reviewer #1805

RalfJung opened this issue May 3, 2024 · 2 comments
Labels
A-assign-PR Area: PR auto assignment and welcome messages

Comments

@RalfJung
Copy link
Member

RalfJung commented May 3, 2024

In Miri, this is our configuration. If we now do r? @user, then nothing happens -- nobody gets assigned, but also no error is shown.

@RalfJung RalfJung changed the title "r?" silenly does nothing when the user is not a reviwer "r?" silently does nothing when the user is not a reviewer May 3, 2024
@apiraino
Copy link
Contributor

apiraino commented May 3, 2024

Tried to look at the triagebot logs but don't have enough visibility. I suspect something fails when the triagebot tries to pick someone from this this file but I don't see errors, this could be why the silent failure.

@ehuss
Copy link
Contributor

ehuss commented May 3, 2024

r? requires an assign.owners table to work. This was required to support the transition from highfive (so two bots didn't respond to every PR). Otherwise it is ignored.

It may be possible to do something like have an empty owners table to enable it and support something like #1806, but currently that is not supported. In the meantime, you can do the more explicit syntax of @rustbot assign @user

@ehuss ehuss added the A-assign-PR Area: PR auto assignment and welcome messages label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-assign-PR Area: PR auto assignment and welcome messages
Projects
None yet
Development

No branches or pull requests

3 participants