Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename enable_interrupts_and_hlt to enable_and_hlt? #205

Closed
toku-sa-n opened this issue Nov 10, 2020 · 4 comments · Fixed by #206
Closed

Rename enable_interrupts_and_hlt to enable_and_hlt? #205

toku-sa-n opened this issue Nov 10, 2020 · 4 comments · Fixed by #206

Comments

@toku-sa-n
Copy link
Member

The name of this method is well-named, but a bit long. Also, since the name of the module is interrupts, interrupts::enable_interrupts_and_hlt repeats interrupts. How about enable_and_hlt? We can use this like interrupts::enable_and_hlt.
@phil-opp
Copy link
Member

Sounds reasonable to me! We could leave the old name as a deprecated alias for a few releases to avoid breakage.

@toku-sa-n
Copy link
Member Author

Deprecating is breaking, so is it better to add this to #193 and get others' opinions?

@phil-opp
Copy link
Member

How is deprecating breaking? Both function names would continue to work, only one would show a "deprecated" warning.

@toku-sa-n
Copy link
Member Author

toku-sa-n commented Nov 11, 2020 •
edited
Loading

Ah, then there's no need to do that.

@toku-sa-n toku-sa-n mentioned this issue Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename enable_interrupts_and_hlt to enable_and_hlt toku-sa-n/x86_64
2 participants
@phil-opp @toku-sa-n