Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_android_with_fallback never uses getrandom on musl #600

Closed
tamird opened this issue Feb 4, 2025 · 3 comments · Fixed by #602
Closed

linux_android_with_fallback never uses getrandom on musl #600

tamird opened this issue Feb 4, 2025 · 3 comments · Fixed by #602

Comments

@tamird
Copy link
Contributor

tamird commented Feb 4, 2025

This regressed in #508.

dlsym can't look up a statically linked symbol, and the result is always falling back to /dev/urandom.
@tamird tamird mentioned this issue Feb 4, 2025
Closed
@newpavlov newpavlov mentioned this issue Feb 5, 2025
Merged
@ibigbug
Copy link

ibigbug commented Feb 9, 2025

cant find libc for android https://github.com/Watfaq/clash-rs/actions/runs/13223451985/job/36911315657?pr=686#step:10:898

any chance these are related?

@tamird
Copy link
Contributor Author

tamird commented Feb 9, 2025

@ibigbug you seem to be using 0.3.0 which doesn't build on android. See #588.

@newpavlov please consider yanking 0.3.0.

@dhardy
Copy link
Member

dhardy commented Feb 9, 2025

@tamird yanking a crate because it doesn't build on one platform creates more issues than it solves; see when to yank. In most cases new users will automatically use the latest patch version anyway (though apparently not this time).

@newpavlov newpavlov mentioned this issue Feb 12, 2025
Merged
newpavlov added a commit that referenced this issue Feb 12, 2025
@newpavlov
linux_android_with_fallback: add cfg to test that fallback is not tri…
074b15b 
…ggered (#605)

The test is needed to prevent potential regressions like #600.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dhardy @ibigbug @tamird