Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: There's no need to run unit tests/coverage for all crates if a PR touches only a specific crate and *nothing* workspace-wide #791

Open
epilys opened this issue Dec 6, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@epilys
Copy link
Member

epilys commented Dec 6, 2024

While CI runs don't take long, it feels kind of wasteful to run tests for the entire workspace when we have binary crates (e.g. no other crate depends on each vhost device crate). Plus flakey test failures from other crates can affect an unrelated PR. We could generate the test pipelines in a different way compared to other rust-vmm repos. However this is low-hanging fruit and not important or urgent.

@stefano-garzarella stefano-garzarella added the good first issue Good for newcomers label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants