Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a color crashes website #67

Open
imMatheus opened this issue Jan 18, 2024 · 2 comments
Open

Removing a color crashes website #67

imMatheus opened this issue Jan 18, 2024 · 2 comments

Comments

@imMatheus
Copy link

When being on the https://www.shadergradient.co/customize site, removing a color from the color picker (meaning removing the entire hex color) makes the entire website crash. I have included a very short video showing the steps needed to reproduce it.

But here is also a step-by-step guide on to reproduce it

  1. Be on the https://www.shadergradient.co/customize URL
  2. Press the colors tab
  3. Pick any of the 3 colors and press the hex value to select it, then remove it
  4. Website should now have crashed
Screen.Recording.2024-01-18.at.23.55.20.mov

A proposed solution from a UX perspective is to not commit the state change if the color is invalid. Meaning, that if a user has three colors, #ff0000, #00ff00 and #0000ff (Red, Green and Blue) then decides to remove the last color, we do not actually change the state and keep showing that color until a new valid color replaces it

@ruucm
Copy link
Owner

ruucm commented Jan 19, 2024

Hey thanks for reporting this. yeah we are refactoring the whole websites including performance improvements. Will add this fix also :)

@imMatheus
Copy link
Author

Great, thanks 🙌 PS: Really love the website, its stunning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants