Added examples, loosely based on some existing johnny-five examples #26
Conversation
|
I'll update with some jshint cleanup as required by Travis CI |
|
I really wish we had a spark core component for fritzing... |
|
Wooo! Check this out: https://github.com/technobly/SparkCore-Fritzing Let's get your new examples landed and then we'll split up the work into issues for each example. |
| token: process.env.SPARK_TOKEN, | ||
| deviceId: process.env.SPARK_DEVICE_ID | ||
| }), | ||
| port: "/dev/cu.usbmodem1421" |
There was a problem hiding this comment.
This will be ignored since the port argument would've been used by Serialport—this line can be removed
There was a problem hiding this comment.
Ah, right. I just copied this over from J5, but probably not relevant to Spark at all. Just delete this example you think?
Based on suggestions by @rwaldron
|
FYI I decided against adding Johnny-Five as a devDependency in the package.json file because technically it's only needed for specific examples, not for developing the library itself. And where do you stop? Do I add temporal? keypress? etc. I figured users of the examples will just have to npm install what they need for that particular one. Is that the right way to go? |
|
@Resseguie I would put these:
In regular dependencies |
|
So, I think I jumped the gun and landed this too soon—looks like you're still making changes. I'm really sorry, but let's close out this branch and PR and any new examples can branch from master |
|
Next time I'll wait until you give me the green light to land stuff |
|
But are they really dependencies? You don't have to have any of them to use spark-io by itself. |
|
I will make sure I get the last commit here |
yeah good point... I say we omit them and if anyone tries to run the program it will fail fast and they will figure it out |
|
I think the only other one I added was the servo docs and diagram. You going to cherry pick it or you want me to make new PR? |
|
@Resseguie I got it: 504b615 Super sorry about that |
|
No problem. I'm going to tweak that LED diagram and do a PR on Johnny-Five too since it's missing that one as well. |
|
@Resseguie I just made you a repo collaborator, so for now just make PRs and I'll review them, but I'll leave you to land them when you're ready. |
|
@rwaldron awesome, thanks! |
|
@Resseguie no, thank you! Your work on this has been awesome :) |
Adds some examples as requested by #9
These have been tested successfully with the latest versions of J5/spark-io/voodoospark (following the PWM commits).