From efd71c6f8da6fd061b7f169472a6a6a8034c8ab3 Mon Sep 17 00:00:00 2001
From: Ryan Tolboom <rxt1077@njit.edu>
Date: Mon, 22 Jan 2024 14:37:07 -0500
Subject: [PATCH] fix: generate alt text from filename for data-uri images

Use file name when alt text not specified for data-uri images.
Now uses image location instead of src attribute.

Closes #1114
---
 pkg/renderer/sgml/html5/image_test.go | 16 ++++++++++++++++
 pkg/renderer/sgml/image.go            |  2 +-
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/pkg/renderer/sgml/html5/image_test.go b/pkg/renderer/sgml/html5/image_test.go
index dae88715..291dcd9e 100644
--- a/pkg/renderer/sgml/html5/image_test.go
+++ b/pkg/renderer/sgml/html5/image_test.go
@@ -427,5 +427,21 @@ image::favicon-glasses-16x16.png[Glasses]`
 			Expect(RenderHTML(source)).To(MatchHTML(expected))
 			// TODO: check that the log/output contains a WARNING message (`image to embed not found or not readable`)
 		})
+
+		It("missing alt text", func() {
+			source := `
+:imagesdir: ../../../../test/images
+:data-uri:
+
+image::favicon-glasses-16x16.png[]`
+
+			expected := `<div class="imageblock">
+<div class="content">
+<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABSklEQVQ4je2Rz0oCURSHT7ipd5ByExGmc28zc++M946OIrhxGgxHqE2N7XJVy8I3cCO4dB2hLnwC+4MY+A6CLgUV3BrObVFOYZugrR+c1fdbnPM7ABt+sgUAgT/kAl/ZTxBhL5jwuZw6WWq261G7uJCT1hhR3pUIr0uE1xHlXTlpjaldXGi268kpa4kJnyPCn0FS2SM7vxX55lQ4rZlwWjORb0yEcXEnEOVDRPnQuLwX+cbk2zengp3dCET4Axwd06jhln25GrNUERLhOUllp2ap8ssbbllEZD0CwaC+o9lX7+sB3bn2wrK8e4hjezGn5K17zS4uQqHQNgAAYJp4tWp9f71stSewZr6tesK62c9We/6ZVq0vkJZ48ouUFB0jGu+omcJISecGiLA2QnR/5aMKO0CEtZV0bqBmCiNE452wGkP/f/wGAAD4AGCWrt/5+Pc0AAAAAElFTkSuQmCC" alt="favicon glasses 16x16">
+</div>
+</div>
+`
+			Expect(RenderHTML(source)).To(MatchHTML(expected))
+		})
 	})
 })
diff --git a/pkg/renderer/sgml/image.go b/pkg/renderer/sgml/image.go
index ad4d398c..3d1ae511 100644
--- a/pkg/renderer/sgml/image.go
+++ b/pkg/renderer/sgml/image.go
@@ -46,7 +46,7 @@ func (r *sgmlRenderer) renderImageBlock(ctx *context, img *types.ImageBlock) (st
 		return "", errors.Wrap(err, "unable to render image")
 	}
 	src := r.getImageSrc(ctx, img.Location)
-	alt, err := r.renderImageAlt(img.Attributes, src)
+	alt, err := r.renderImageAlt(img.Attributes, img.Location.ToString())
 	if err != nil {
 		return "", errors.Wrap(err, "unable to render image")
 	}