Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The way to calculate zllNextPhaseCycle in OOOCoreRecorder::cSimStart seems wrong (?) #270

Open
jesuszhu opened this issue Aug 1, 2024 · 0 comments

Comments

@jesuszhu
Copy link

jesuszhu commented Aug 1, 2024

uint64_t OOOCoreRecorder::cSimStart(uint64_t curCycle) {
    uint64_t nextPhaseCycle = zinfo->globPhaseCycles + zinfo->phaseLength;
    uint64_t zllNextPhaseCycle = nextPhaseCycle - gapCycles;

    [And later...]
        // Taper phase if it's not already tapered
        if (lastEvProduced->zllStartCycle < zllNextPhaseCycle) {
            addIssueEvent(nextPhaseCycle);
        }

This zllNextPhaseCycle seems confusing. As the name implies (also it's compared with another zll cycle later) it should be in zll clocks. However by nextPhaseCycle - gapCycles it's neither in zll clocks nor in phase 1 clock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant