Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big update in light of Lockup merger #203

Open
PaulRBerg opened this issue Dec 5, 2024 · 6 comments · May be fixed by #238
Open

Big update in light of Lockup merger #203

PaulRBerg opened this issue Dec 5, 2024 · 6 comments · May be fixed by #238
Assignees
@smol-ninja
Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Dec 5, 2024 •
edited by smol-ninja
Loading

In Lockup V2.0.0, we have decided to merge the LockupLinear, LockupTranched, and LockupDynamic contracts. Context here: sablier-labs/lockup#1064

Many parts of the docs will have to be updated.
@PaulRBerg PaulRBerg added effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Dec 5, 2024
@PaulRBerg PaulRBerg mentioned this issue Dec 17, 2024
Open
@smol-ninja smol-ninja self-assigned this Jan 16, 2025
@smol-ninja

This comment has been minimized.

Sign in to view
@PaulRBerg

This comment has been minimized.

Sign in to view
@smol-ninja smol-ninja linked a pull request Jan 16, 2025 that will close this issue
Open
6 tasks
@smol-ninja
Copy link
Member

Should we have three categories in reference section: lockup, airdrops and flow? Preview here.

Image

@andreivladbrg
Copy link
Member

Should we have three categories in reference section: lockup, airdrops and flow? Preview here.

IMO we should have 3 diferent sections.

@razgraf
Copy link
Member

razgraf commented Jan 23, 2025 •
edited by smol-ninja
Loading

Posting here from Slack (some of the things are probably already done, but just making sure)

  • Lockup merged and all the examples
  • Definitions and examples of cliff streams that isn't ratio-based now
  • A note under shapes like Unlock Cliff and Unlock Linear that they can now be done using either LL or LD
  • Instant / ranged airdrops
  • Fees (I need a good explainer page for this so I can link to it from the app in the places we charge fees for)

Also, the App and API sections might have mentions to "different contracts" when discussing LL/LD/LT - now that we have the monolithic architecture, could you have a look over those areas as well? I'll add a reminder in our own list of pre-launch tasks as well.

@smol-ninja
Copy link
Member

smol-ninja commented Jan 23, 2025 •
edited
Loading

Some of the content on "Use Cases" page will become outdated after we launch Merkle Instant. It is not a good idea to scream the flaws of the instant airdrops anymore. I have replaced the criticizing section with the benefits of using Sablier to run instant airdrop campaigns: https://docs-jnmtlsx7x-sablier.vercel.app/concepts/use-cases.

@maxdesalle whenever you have time, can you look over the content and make it better please? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Q1 2025 Release sablier-labs/docs
4 participants
@smol-ninja @PaulRBerg @razgraf @andreivladbrg