Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance on how to reproduce bytecodes #234

Open
PaulRBerg opened this issue Dec 9, 2023 · 7 comments
Open

Provide guidance on how to reproduce bytecodes #234

PaulRBerg opened this issue Dec 9, 2023 · 7 comments
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: docs Changes to documentation. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@PaulRBerg
Copy link
Member

Third-parties may be interested in reproducing the bytecodes deployed on Mainnet. To assist them, we should provide a wiki or some sort of docs for how to recompile the contracts and passing the appropriate constructor arguments.

More context here:

https://discord.com/channels/883432404780466176/1077650654396428348/1183046520975675462

@PaulRBerg PaulRBerg added type: docs Changes to documentation. priority: 2 We will do our best to deal with this. effort: low Easy or tiny task that takes less than a day. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. labels Jan 1, 2024

This comment was marked as resolved.

@github-actions github-actions bot added the stale Inactive for a long time. label Jul 7, 2024
@PaulRBerg

This comment was marked as resolved.

@PaulRBerg PaulRBerg removed the stale Inactive for a long time. label Jul 8, 2024
Copy link

This issue is stale because it has been open 182 days with no activity. Leave a comment or remove the "stale" label, otherwise this will be closed in 14 days.

@github-actions github-actions bot added the stale Inactive for a long time. label Jan 12, 2025
@smol-ninja
Copy link
Member

The Discord link isn't showing the message anymore. May I know what the original ask was? I am curious as to why someone would be interested in "reproducing" the bytecode. If they need to use the bytecode, they can copy it from Etherscan.

@PaulRBerg
Copy link
Member Author

I would keep this issue open.

It's a low-priority task, but somewhat important for decentralization purposes.

The bytecodes can be copied from Etherscan, but the purpose of reproducing them from a Foundry repo is to enable developers to trustlessly verify that the source code in the repo matches the contracts on Etherscan.

Another way would be to diff-check the verified source code, but this approach is way more time-consuming (because there are many different files to verify).

@smol-ninja
Copy link
Member

I see. Thanks for explaining.

But any experienced developer can verify it even right now. We log all deployment files in the deployments repo which contains all constructor arguments used at the time of deployment. So it's just a matter of printing the bytecode using the Foundry script and comparing it with Etherscan's displayed bytecode.

That said, would it not be more appropriate to provide the guidance in the docs repo?

@PaulRBerg
Copy link
Member Author

But any experienced developer can verify it even right now

  1. Not all developers are experienced
  2. Even for experienced folks, a little guidance can be helpful, e.g. what Foundry profile and settings to use, etc.

it's just a matter of printing the bytecode using the Foundry script and comparing it with Etherscan's displayed bytecode

This 'matter' is precisely what should be documented.

would it not be more appropriate to provide the guidance in the docs repo?

Yes. I have transferred the issue to the docs repo.

@PaulRBerg PaulRBerg transferred this issue from sablier-labs/lockup Jan 13, 2025
@github-actions github-actions bot removed the stale Inactive for a long time. label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Easy or tiny task that takes less than a day. priority: 2 We will do our best to deal with this. type: docs Changes to documentation. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Development

No branches or pull requests

2 participants