Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_empty_diffs config does not work #119

Closed
ilyagr opened this issue Jul 5, 2024 · 2 comments
Closed

skip_empty_diffs config does not work #119

ilyagr opened this issue Jul 5, 2024 · 2 comments

Comments

@ilyagr
Copy link
Contributor

ilyagr commented Jul 5, 2024

I set up my viddy.toml as follows:

[general]
shell = "echo"  # To check that this is the correct config file path
skip_empty_diffs=true

However, the skip_empty_diffs option did not take. Here's the result of viddy abracadabra with that config:

image

I'm using viddy 0.4.0 installed form Nix, on Mac OS Sonoma 14.5, Apple Silicon

I'm not sure what's going on, my understanding of 106e52d#diff-0e426a43248661127a0c0ee115aef7a1093b635f8993b3f7ebb1dd9f05b8f249R153 is that the option should work, which is why I filed #118.

@sachaos
Copy link
Owner

sachaos commented Aug 17, 2024

This bug fixed in viddy v1.0.0-rc.1
#117 (comment)

@sachaos
Copy link
Owner

sachaos commented Aug 22, 2024

Viddy v1.0.0 is available now.

@sachaos sachaos closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants