Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env variables returning null if config is cached #11

Open
jeygith opened this issue Feb 28, 2018 · 4 comments
Open

env variables returning null if config is cached #11

jeygith opened this issue Feb 28, 2018 · 4 comments

Comments

@jeygith
Copy link

jeygith commented Feb 28, 2018

Hi! good work on this however, there's a slight issue with how you get the env variables in the Mpesa class. Once the config is cached, via config:cache, the .env file is no longer loaded and calls to the env function return null. I'd suggest you create a config file for the sdk where the consumer keys and secret or any other variable can be set.

@mossey
Copy link
Contributor

mossey commented Mar 21, 2018

Hello @jeygith , thanks for the feedback. I have taken the issue into consideration and we will include that fix in our next release.

@nikklass
Copy link

These can be fixed on the move, you dont need to wait for a whole release to correct such. Are pull requests ok?

@mossey
Copy link
Contributor

mossey commented Sep 15, 2018

Yeah @nikklass PRs are okay

@jaymoh
Copy link

jaymoh commented Jul 30, 2021

@nikklass hi, did you create this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants