Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add natively staked assets in the Safe balances #2043

Open
hectorgomezv opened this issue Oct 22, 2024 · 1 comment
Open

Add natively staked assets in the Safe balances #2043

hectorgomezv opened this issue Oct 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@hectorgomezv
Copy link
Member

hectorgomezv commented Oct 22, 2024

Description

On Native Staking, the user does not get any asset in return. So the Safe{Wallet} interface does not show any data about the natively staked assets, and their fiat values are also missing from the total balance.

The current flow in the CGW is to check the wallet assets via the Safe Transaction Service API, so it would be necessary to include the staking provider API in the process somehow. As this shouldn't be done for each balance request, ideally an indicator of whether the wallet has staked assets would be needed, and (TBD) this data should be stored in the CGW.

Requirements

  • Include the natively staked ETH in the CGW balances responses.
@hectorgomezv hectorgomezv added the enhancement New feature or request label Oct 22, 2024
@hectorgomezv hectorgomezv changed the title Add native staked amounts the to the Safe balance Add natively staked assets in the Safe balances Oct 22, 2024
@iamacook
Copy link
Member

Having briefly looked into this, we can get the overall balance from the widget endpoint (checking that it's dedicated staking): https://safe.widget.kiln.fi/api/stakes?wallet={{safeAddress}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants