Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/migrate to Safe Decoder Service #2308

Open
iamacook opened this issue Jan 28, 2025 · 1 comment · May be fixed by #2313
Open

Add/migrate to Safe Decoder Service #2308

iamacook opened this issue Jan 28, 2025 · 1 comment · May be fixed by #2313
Assignees
Labels
enhancement New feature or request

Comments

@iamacook
Copy link
Member

Description

The Safe Decoder Service effectively replaces the data decoder of the Transaction Service. It improves upon the existing implementation, particularly by following proxy contracts. We should migrate to the service due to this.

The return type of the new service differs to the existing one and it is used extensively across mappers. We should (initially) consider remapping the response for direct usage and push to deprecate it, across all entities that use it as well.

Requirements

  • Add Safe Decoder datasource and entities.
  • Add compatibility layer between existing data structure and new one.
  • Address migration to new structure (likely in follow up issues)

Additional information

No response

@iamacook iamacook added the enhancement New feature or request label Jan 28, 2025
@iamacook
Copy link
Member Author

I have already stashed a local implementation of the relative datasource/domain layers from initial experimentation.

@iamacook iamacook self-assigned this Jan 29, 2025
@iamacook iamacook linked a pull request Jan 29, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant