You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current review script only checks for line changes, not the exact change in the deployment types.
So, if say there is an entry as:
"someChainID": ["canonical", "eip155"]
then, if the PR removes one of the deployment types, it will still pass the review check.
"someChainID": "canonical"
This issue is limited to v1.3.1.
Expected Outcome
To check the PR is not removing any current deployment types from the deployment list.
The text was updated successfully, but these errors were encountered:
remedcu
changed the title
Safe Deployment Review Script check for removal of previous chain
Review Script to check for removal of previous deployment types
Jul 9, 2024
The current review script only checks for line changes, not the exact change in the deployment types.
So, if say there is an entry as:
then, if the PR removes one of the deployment types, it will still pass the review check.
This issue is limited to
v1.3.1
.Expected Outcome
To check the PR is not removing any current deployment types from the deployment list.
The text was updated successfully, but these errors were encountered: