Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESR91: Calculate lowest common denominator above 1.5 for pixel ratio producing even result #1085

Open
rainemak opened this issue Sep 29, 2024 · 1 comment
Open

ESR91: Calculate lowest common denominator above 1.5 for pixel ratio producing even result #1085

rainemak opened this issue Sep 29, 2024 · 1 comment
Labels
esr91 Changes required to support Gecko ESR 91

Comments

@rainemak
Copy link
Member

rainemak commented Sep 29, 2024 •
edited
Loading

Calculate lowest common denominator above 1.5 for pixel ratio producing even result.

Xperia 10 V screen resolution is 1080 x 2520.
Android FF has 2.608695652173913
We have 3.0 (we had this approach for quite some time)

1080 / 2.608695652173913 = 414
2520 / 2.608695652173913 = 966

Producing a little bit small rending result but would match to Android FF.
@rainemak rainemak added the esr91 Changes required to support Gecko ESR 91 label Sep 29, 2024
@rainemak
Copy link
Member Author

rainemak commented Oct 2, 2024

We could actually have map of fixed nice looking pixel rations per resolution starting from 1080x2520 initial value.

@rainemak rainemak mentioned this issue Oct 2, 2024
Closed
@rainemak rainemak changed the title ESR91: Calculate lowest common denominator above 2.0 for pixel ratio producing even result ESR91: Calculate lowest common denominator above 1.5 for pixel ratio producing even result Oct 2, 2024
rainemak added a commit to sailfishos/sailfish-components-webview that referenced this issue Oct 2, 2024
@rainemak
[components-webview] Create screen resolution to layout.css.devPixels…
b94cf08 
…PerPx mapping. JB#62599

This is rather simple way to map these. At the same, there ain't
that many screen resolution that we'd like to map. Thus, this
approach is reasoble for our needs.

For testing this, if you have ran browser at least once, you need to
remove __PREFS_WRITTEN__ flag file from your device.

> rm $HOME/.local/share/org.sailfishos/browser/__PREFS_WRITTEN__

GitHub issue:
sailfishos/sailfish-browser#1085
rainemak added a commit to sailfishos/sailfish-components-webview that referenced this issue Oct 10, 2024
@rainemak
[components-webview] Create screen resolution to layout.css.devPixels…
3f5da1c 
…PerPx mapping. JB#62599

This is rather simple way to map these. At the same, there ain't
that many screen resolution that we'd like to map. Thus, this
approach is reasoble for our needs.

For testing this, if you have ran browser at least once, you need to
remove __PREFS_WRITTEN__ flag file from your device.

> rm $HOME/.local/share/org.sailfishos/browser/__PREFS_WRITTEN__

GitHub issue:
sailfishos/sailfish-browser#1085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
esr91 Changes required to support Gecko ESR 91
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rainemak