Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESR91: Quoting on discourse does not work, you can select text but pressing overlay buttons fail #1086

Open
rainemak opened this issue Oct 1, 2024 · 0 comments
Labels
esr91 Changes required to support Gecko ESR 91

Comments

@rainemak
Copy link
Member

rainemak commented Oct 1, 2024

REPRODUCIBILITY: 100%
ESR91 (sailfishos-esr91 branches):

  • xulrunner-qt5 - 79d6d7a173cc9b7c4e0d8906503ca72eaf37954f
  • embedlite-components-qt5 - 87b37162ad146025cc26971f42bbe585e1c3234a
  • sailfish-components-webview - 1df906017c9fb8d69ec56f6ccb6065625b3ea8d2
  • qtmozembed-qt5 - 7c21d5a6c6a6c3ed1e992b56decdf350308db7ed
  • sailfish-browser - 0c54e26

DID IT WORK CORRECTLY IN THE PREVIOUS PUBLIC RELEASE: Yes (esr78)

DESCRIPTION:

Quoting on discourse does not work, you can select text but pressing overlay buttons fail. For example Sailfish OS Forum is discourse based.

PRECONDITIONS:

esr91 installed

STEPS TO REPRODUCE:

  1. Open forum.sailfishos.org
  2. Open a topic
  3. Long press on top of comment text until text selection activates
  4. Press Quote from the overlay below the text selection

EXPECTED RESULT:

Reply box activates and selected text is quoted in the reply box.

ACTUAL RESULT:

Nothing happens. Only selected text is copied to clipboard upon selection as it should happen.

ADDITIONAL INFORMATION:

Edit option is similarly broken.

Worth checking that these are still working. Whilst browser ui side selectors are active we should past through some touch events for web content.
sailfishos/sailfish-components-webview#152
#982

@rainemak rainemak added the esr91 Changes required to support Gecko ESR 91 label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esr91 Changes required to support Gecko ESR 91
Projects
None yet
Development

No branches or pull requests

1 participant