Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create histogram style filter component #98

Open
alexluscombe opened this issue Dec 25, 2018 · 9 comments
Open

Create histogram style filter component #98

alexluscombe opened this issue Dec 25, 2018 · 9 comments

Comments

@alexluscombe
Copy link
Member

Create a histogram style filter component. e.g. see price filtering component on Airbnb search results page. Component should include all the functionality from the AIrbnb version.

image

Component should allow the user to see the distribution of values of a particular field and allow them to narrow results by dragging the handles at the upper and lower ends of the slider. Slider handles should not be allowed to cross over one and other.

As the handles are dragged along the slider the user should be able to see how they are changing the filter values. A Clear button should reset the component to its original state. An apply button should run the search with the new parameters set.

@alexluscombe alexluscombe changed the title Creat histogram style filter component Create histogram style filter component Dec 25, 2018
@zlatanpham
Copy link
Contributor

Hey @alexluscombe, I've made a prototype for the component, available to check here. Can you take a look to see whether its behaviors meet your need? (note: just for desktop, not support touch for mobile yet).

@mish15
Copy link
Member

mish15 commented Jan 9, 2019

@zlatanpham nice! Would be good to be able to set a different colour for the selected region of the histogram. Also would be good to get the mobile drag working if possible also?

@zlatanpham
Copy link
Contributor

@mish15 you meant color of the highlighted area on the attachment could be changed?
screen shot 2019-01-09 at 9 35 21 am
For the mobile drag support, no worries, I did complete the feature yesterday.

@mish15
Copy link
Member

mish15 commented Jan 9, 2019

@zlatanpham yes exactly. I would guess normally the selected area would be coloured and the areas outside would be greyed out. Probably useful to be able to set both though

@zlatanpham
Copy link
Contributor

@mish15 👍 I'll post the demo once completed.

@zlatanpham
Copy link
Contributor

@mish15 here is the update.

@mish15
Copy link
Member

mish15 commented Jan 9, 2019

Cool perfect!

@alexluscombe
Copy link
Member Author

Hi @zlatanpham We're happy with the prototype. Can you create a PR for @benhinchley to review?

@zlatanpham
Copy link
Contributor

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants