New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsident behavior on null path between production and development #132

Open

samselfridge-cnc opened this issue Sep 6, 2024 · 0 comments

samselfridge-cnc commented Sep 6, 2024

Using
"redux-first-history": "5.2.0",
"history": "4.10.1" (goes with router v5)
"react-router-dom": "5.3.4"

When I dispatch a push() with a null value the behavior is different in developement vs production.

In Dev: No URL change
In Production: Removes query params from existing URL

This is caused by of a dev check in the history push method (see screenshot).

Possibly expected behavior, had same behavior in connected-react-router but could be fixed with an earlier null check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment