Add edit option to clear note #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: samg#164 The regex used to see if a note has been provided cannot find empty strings. It is therefore not possible to look for empty string to clear a note. Instead a new flag (-c or --clear) clears the last entry's note or it can be used with the -i flag to clear another entry's note.
fbuys
commented
Sep 14, 2021
| @@ -247,14 +248,18 @@ def edit | |||
| end | |||
|
|
|||
| if Config['note_editor'] | |||
| if args['-z'] | |||
| if args['-c'] | |||
There was a problem hiding this comment.
🥦 If -c is provided it will clear even if a note is provided. In other words clearing is prioritized.
| @@ -340,6 +350,20 @@ def invoke command | |||
| expect(Timetrap::Timer.active_entry.note).to eq 'running entry//appended in editor' | |||
| end | |||
| end | |||
|
|
|||
| context "clearing" do | |||
There was a problem hiding this comment.
🥦 Specs with the editor
| @@ -211,6 +211,16 @@ def invoke command | |||
| expect(Timetrap::Timer.active_entry.note).to eq 'running entry//new//more' | |||
| end | |||
|
|
|||
| it "should allow clearing the description of the active period" do | |||
There was a problem hiding this comment.
🥦 Specs similar to --append specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #164
A new flag (-c or --clear) clears the last entry's note or it can be used with the -i flag to clear another entry's note.
Motivation and Context
The regex used to see if a note has been provided cannot find empty
strings. It is therefore not possible to look for empty string to clear
a note.
How Has This Been Tested?
Added specs.
Created an entry with a note and cleared it with both
-cand--clear.Also turned
note_editoron and confirmed that notes are cleared without the note editor opening again.Types of changes
Checklist: