Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current specs are failing #194

Closed
mralexandernickel opened this issue Mar 16, 2021 · 0 comments
Closed

Current specs are failing #194

mralexandernickel opened this issue Mar 16, 2021 · 0 comments

Comments

@mralexandernickel
Copy link
Contributor

While trying to fix a bug in timetrap I noticed that the specs are failing on master-branch.
The failing specs are all related to #163. I already found and fixed #163 locally which is also fixing the specs.
Guess it would make sense to also add a gh-action on pull_request event, to prevent problems like this.
WiIl open a PR which fixes the icals and the failing specs this evening (I am from Germany, so "within the next 4-5 hours").
dechimp pushed a commit to dechimp/timetrap that referenced this issue Jul 14, 2021
@mralexandernickel @dechimp
ci: Add github-action to run rspec
dc940c0 
This is also update icalendar to the latest version.

Closes: samg#194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mralexandernickel