Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigdecimal no longer part of the default gems warning #219

Open
bgsmase opened this issue Jan 17, 2025 · 3 comments
Open

bigdecimal no longer part of the default gems warning #219

bgsmase opened this issue Jan 17, 2025 · 3 comments

Comments

@bgsmase
Copy link

bgsmase commented Jan 17, 2025

I have started getting warnings such as below when executing timetrap commands using version 1.15.2:

lib/ruby/gems/3.3.0/gems/sequel-5.30.0/lib/sequel.rb:3: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0. You can add bigdecimal to your Gemfile or gemspec to silence this warning.

I see from looking at the sequel code that this was fixed there in jeremyevans/sequel@c6a0178 and so should be in versions from 5.72.0 and later of sequel. Timetrap currently depends on version sequel 5.30.0 so can this be updated.

@SebastianBalle
Copy link

@dechimp Could you help resolve this? I see you made the last commit to the project. I have similar issue when installing timetrap from nixpgs

@dechimp
Copy link
Collaborator

dechimp commented Jan 31, 2025

I might need some help with this, because I am new with maintaining packages.

I noticed just now that I had not run git tag --push, so 1.15.4 as of now should now be the latest tag. But on rubygems, the latest version of timetrap has been 1.15.4 for some time (https://rubygems.org/gems/timetrap/versions/1.15.4).

However I see you are installing it from nix. To update timetrap on nix, does someone need to make a PR and change the Gemfile.lock (nixpkgs). Are there nix maintainers that do this for this package? If you know, please let me know.

Otherwise I would recommend just installing directly from rubygems gem install timetrap.

@jerith666
Copy link

jerith666 commented Feb 1, 2025

Hmm, I fixed it in my fork of nixpkgs like so: jerith666/nixpkgs@61bcbed. I meant to open a PR to upstream that, but it looks like I never did. And maybe that's good, because it sounds like you're saying that isn't the right fix! :)

Nixpkgs is currently on 1.15.2. I don't see anything in the changes from that version to 1.15.4 that would address this problem. Am I right in understanding that the fix would be to bump the version here?

spec.add_dependency "sequel", "~> 5.30.0"

If such a fix is made here and a new version released, I can take care of updating nixpkgs to use that new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants