-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all embed URLs dynamically #345
Comments
Good idea and should be pretty straight forward with a bit of Regex. I think even the Vimeo new API will parse a URL anyway. I'll give it a go. Cheers 👍 |
In the mean time, I'm actually using this: https://github.com/Zod-/jsVideoUrlParser |
@gurupras has done a PR for this and I've just modified it slightly to support Vimeo also. Will be pushing to master shortly and deploy 2.0.10 👍 |
Added in v2.0.10: |
This idea would work well especially if this library were a web component, like mentioned here. I'm trying to support a video player where I don't know until runtime which type of URL is going to be inserted into the player. I'm going to have to do all of the logic myself, parsing the URLs to see if they are from YouTube, Vimeo, or just a plain file, and then I'll have to extract the ids. It would be great if the player supported any URL, for example:
or
Both of the above would work, and all of the logic would be contained inside of the component.
The text was updated successfully, but these errors were encountered: